JuliaStats / RDatasets.jl

Julia package for loading many of the data sets available in R
GNU General Public License v3.0
160 stars 56 forks source link

Dimspec not defined #4

Closed staticfloat closed 11 years ago

staticfloat commented 11 years ago

One both OSX and Ubuntu, after a Pkg.init(); Pkg.update(); Pkg.add("RDatasets"); load("RDatasets"); I get the following:

julia> load("RDatasets")
Warning: replacing module DataFrames
Warning: New definition +(BitArray{N},AbstractArray{T,N}) at /home/sabae/src/julia/base/bitarray.jl:992 is ambiguous with +(AbstractArray{T,N},BitArray{N}) at bitarray.jl:993.
         Make sure +(BitArray{N},BitArray{N}) is defined first.
...
<many identical warnings for a large number of operators>
...
Dimspec not defined
 in load_now at util.jl:235
 in require at util.jl:185
 in load_now at util.jl:235
 in load_now at util.jl:235
 in load_now at util.jl:247
at /home/sabae/src/julia/base/bitarray.jl:1406
johnmyleswhite commented 11 years ago

My guess is that this is caused by the recent change of load's semantics. I thought we were reversing that decision until we have a coherent plan?

JeffBezanson commented 11 years ago

It looks like something is trying to load a second copy of bitarray (which is now in Base)?

johnmyleswhite commented 11 years ago

Yes. The offender is this:

load("DataFrames")

module RDatasets
  export data

  using Base

  load("DataFrames")
  using DataFrames

  load("RDatasets/src/data.jl")
  load("RDatasets/src/datasets.jl")
  load("RDatasets/src/available_datasets.jl")
end

Removing the second load call fixes things.

johnmyleswhite commented 11 years ago

Fixed by 97460aa33554dcadd9311cad8177234087a0c5ee

staticfloat commented 11 years ago

Loving that turnaround time. Confirmed working, thanks!