search

JuliaStats / RDatasets.jl

Julia package for loading many of the data sets available in R
GNU General Public License v3.0
159 stars 56 forks source link

Added "drc" package #64

Closed alejandromerchan closed 5 years ago

alejandromerchan commented 5 years ago

Updated "drc" in docs and added "drc" to table in README

randyzwitch commented 5 years ago

(Closed/Opened to trigger CI again)

alejandromerchan commented 5 years ago

Please let me know if I did anything wrong with this PR. I'm still fairly new with git and I haven't had any problems like this before. Thanks

randyzwitch commented 5 years ago

You don't have a git issue here, but rather the tests are failing. The build log can be found at:

https://travis-ci.org/johnmyleswhite/RDatasets.jl/jobs/442691917

alejandromerchan commented 5 years ago

I see. I don't really know much about testing and the test files look arcane. But I can this line in the log ` Expression: size(dfs_found, 1) == size(dfs_documented, 1)

Evaluated: 768 == 733`

I assume I caused that by increasing the number of datasets by 35, but I cannot find any place in the code where I can update that. Or the automatic code somehow isn't reading the new datasets because it doesn't find the new version. Anyway, thanks for your help and I'd love yo learn more about these issues.

alejandromerchan commented 5 years ago

I realized that there's still a DS.Store file in the docs, you mentioned before that those cause test failures, right?