search

JuliaStats / RDatasets.jl

Julia package for loading many of the data sets available in R
GNU General Public License v3.0
159 stars 56 forks source link

upgrade to CSV 0.5 #70

Closed bjarthur closed 5 years ago

bjarthur commented 5 years ago

fixes https://github.com/johnmyleswhite/RDatasets.jl/issues/69

bjarthur commented 5 years ago

tests now pass. any comments? @randyzwitch

randyzwitch commented 5 years ago

Does this PR also fix the issue being worked on in #68?

bjarthur commented 5 years ago

yes, it does. gap::PD is one of a handful of datasets which require special treatment to get the types of columns correct. that PR completely ignores Dataset_typedetect_rows above. this one modifies it to work with the new CSV API.

SimonDanisch commented 5 years ago

Would be great to merge this :)