search

JuliaStats / Statistics.jl

The Statistics stdlib that ships with Julia.
https://juliastats.org/Statistics.jl/dev/
Other
71 stars 40 forks source link

Handle SparseArrays.jl dep as Pkg extension #146

Closed dkarrasch closed 1 year ago

dkarrasch commented 1 year ago

I wonder if we want to/can/should backport this to v1.9 and v1.10?

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 95.08% and project coverage change: +0.01 :tada:

Comparison is base (bb7063d) 96.98% compared to head (0678f7d) 96.99%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #146 +/- ## ========================================== + Coverage 96.98% 96.99% +0.01% ========================================== Files 1 2 +1 Lines 431 433 +2 ========================================== + Hits 418 420 +2 Misses 13 13 ``` | [Impacted Files](https://app.codecov.io/gh/JuliaStats/Statistics.jl/pull/146?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats) | Coverage Δ | | |---|---|---| | [src/Statistics.jl](https://app.codecov.io/gh/JuliaStats/Statistics.jl/pull/146?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats#diff-c3JjL1N0YXRpc3RpY3Muamw=) | `97.31% <ø> (+0.32%)` | :arrow_up: | | [ext/StatisticsSparseArraysExt.jl](https://app.codecov.io/gh/JuliaStats/Statistics.jl/pull/146?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats#diff-ZXh0L1N0YXRpc3RpY3NTcGFyc2VBcnJheXNFeHQuamw=) | `95.08% <95.08%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

dkarrasch commented 1 year ago

Well, backporting to v1.9 doesn't make much sense, I guess, since SparseArrays.jl is in the sysimage. But backporting to v1.10 is important.

dkarrasch commented 1 year ago

Uff, I only now realize this is a duplicate of #134. What needs to be done to get this done? Not having SparseArrays.jl as a weak dependency puts a heavy load (time) on downstream packages like Distances.jl.

nalimilan commented 1 year ago

Not sure. If it is confirmed that weak dependencies don't work for stdlib modules, we will have to finish https://github.com/JuliaLang/julia/pull/46501 first.