search

JuliaStats / Statistics.jl

The Statistics stdlib that ships with Julia.
https://juliastats.org/Statistics.jl/dev/
Other
71 stars 40 forks source link

Work without stdlib `SparseArrays.jl` #163

Open inkydragon opened 7 months ago

inkydragon commented 7 months ago

People could build a julia without SparseArrays.jl by setting the flag USE_GPL_LIBS=0.

xref: https://github.com/JuliaLang/julia/issues/53211

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (68869af) 97.01% compared to head (b63f738) 96.99%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #163 +/- ## ========================================== - Coverage 97.01% 96.99% -0.02% ========================================== Files 2 2 Lines 435 433 -2 ========================================== - Hits 422 420 -2 Misses 13 13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gitboy16 commented 4 months ago

Is there anything else to do on this PR? Thanks

inkydragon commented 4 months ago

@gitboy16

Is there anything else to do on this PR?

There is no explicit use of functions from GPL solver modules (umfpack, cholmod, spqr) in ext/SparseArraysExt.jl.

Maybe we don't need this pr. Waiting for #163.

See also: JuliaLang/julia#54240