search

JuliaStats / Statistics.jl

The Statistics stdlib that ships with Julia.
https://juliastats.org/Statistics.jl/dev/
Other
72 stars 40 forks source link

Convert === 0/0 into isnan #92

Closed pchintalapudi closed 3 years ago

pchintalapudi commented 3 years ago

While the Julia interpreter folds 0/0 into 0xFFF8, LLVM optimizations occasionally constant fold 0/0 into 0x7FF8. Since the sign bit of a NaN is not required to have any particular value, we can use isnan instead of === 0/0 to check these tests.

codecov[bot] commented 3 years ago

Codecov Report

Merging #92 (fde112c) into master (74897fe) will increase coverage by 0.00%. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   96.89%   96.90%           
=======================================
  Files           1        1           
  Lines         419      420    +1     
=======================================
+ Hits          406      407    +1     
  Misses         13       13
Impacted Files Coverage Δ
src/Statistics.jl 96.90% <0.00%> (+<0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 74897fe...fde112c. Read the comment docs.