search

JuliaStats / StatsKit.jl

Convenience meta-package to load essential packages for statistics
Other
139 stars 16 forks source link

Add ShiftedArrays #22

Closed nalimilan closed 3 years ago

nalimilan commented 4 years ago

README.md assumes ShiftedArrays is going to move to JuliaStats.

piever commented 4 years ago

OK, happy to move the repository as soon as the decision on where it goes (JuliaArrays or JuliaStats) is finalized. I may be mildly in favor of moving it to JuliaArrays, of which I'm already a member, but am fine with either option.

nalimilan commented 4 years ago

Ah, right, I also think JuliaArrays is more appropriate. I've asked on Slack.

piever commented 4 years ago

UPDATE: I've just transferred the repository at https://github.com/JuliaArrays/ShiftedArrays.jl

nalimilan commented 4 years ago

Cool. Let's merge? CI failures are timeouts (there are too many tests...).

nalimilan commented 4 years ago

OK to merge?

nalimilan commented 3 years ago

Actually I'm afraid I'm going to have to revert this, as TimeSeries already exports lag, leadanddiff`: https://juliastats.org/TimeSeries.jl/stable/apply/#lag-1

It only provides methods for TimeArray though (and it's a not an AbstractArray), so maybe we can define these functions e.g. in DataAPI so that both packages can extend them.

Cc: @iblis17

iblislin commented 3 years ago

It only provides methods for TimeArray though (and it's a not an AbstractArray), so maybe we can define these functions e.g. in DataAPI so that both packages can extend them.

I'm okay if we define them in DataAPI.