search

JuliaStats / Survival.jl

Survival analysis in Julia
MIT License
73 stars 22 forks source link

Fix StatsModels #16

Closed nignatiadis closed 5 years ago

nignatiadis commented 5 years ago

Hi! This should fix #10, although it might be more elegant to proceed as @kleinschmidt recommended by defining the two lines of logic in StatsModels and including here only:

function concrete_term(t::Term, xs::AbstractVector{<:EventTime}, ::Nothing)
    IdentityTerm(t.sym)
end

@kleinschmidt: Does it matter if we dispatch on concrete_term rather than schema?

kleinschmidt commented 5 years ago

As for dispatching on concrete_term vs. schema, I think you've made the right choice here (and that confusion is why I renamed what used to be methods of schema to concrete_term instead...)

nignatiadis commented 5 years ago

Sounds great, thanks! The new formula system is really cool and what I had been missing most in Julia and ... one of these days (maybe in June) I will find the time to properly implement B/natural-splines..

ararslan commented 5 years ago

Superseded by #17