ararslan commented 2 years ago

Also define methods for modelmatrix and dof_residual.

The direct dependency on StatsBase may actually be unnecessary now but I didn't bother to verify (it's an indirect dependency regardless).

codecov-commenter commented 2 years ago

Codecov Report

Merging #42 (9a56967) into master (c38b803) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files           5        5           
  Lines         228      230    +2     
=======================================
+ Hits          227      229    +2     
  Misses          1        1

Impacted Files	Coverage Δ
src/cox.jl	`99.24% <100.00%> (+0.01%)`	:arrow_up:
src/estimator.jl	`100.00% <100.00%> (ø)`
src/kaplanmeier.jl	`100.00% <100.00%> (ø)`
src/nelsonaalen.jl	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c38b803...9a56967. Read the comment docs.

nalimilan commented 2 years ago

Sorry for the delay. Looks good anyway!

I think the dependency on StatsBase is still needed due to CoefTable being defined there.

ararslan commented 2 years ago

No worries! StatsBase also provides ConvergenceException.

JuliaStats / Survival.jl

Extend functions from StatsAPI instead of StatsBase #42

Codecov Report