search

JuliaStats / TimeModels.jl

Modeling time series in Julia
Other
57 stars 28 forks source link

big overhaul of testing framework, new test only stubbed, old tests ren... #26

Closed milktrader closed 10 years ago

milktrader commented 10 years ago

Failing on this: ERROR: could not open file /home/travis/build/JuliaStats/TimeModels.jl/test/kalman.jl

milktrader commented 10 years ago

Gah, same error:

ERROR: could not open file /home/travis/build/JuliaStats/TimeModels.jl/test/kalman.jl

I have a typo somewhere that is eluding me. The other three files are passing so the framework setup is fine, just this one file.

milktrader commented 10 years ago

btw, I tested this in REPL before committing and it's passing:

julia> @runtest TimeModels kalman

kalman builds models

2 facts verified.
milktrader commented 10 years ago

Alright, this is a Kalman.jl vs kalman.jl issue that OSX hides

papamarkou commented 10 years ago

I may be wrong about this but my view is that we should be comparing the output of the package to that of R, otherwise just checking that the models run is of little (testing) use.

milktrader commented 10 years ago

I very much agree with testing against R packages. This PR just gets the framework working (which it appears to be doing). The existing tests are dummy tests and only check that the cl.values object is recognized, which is the object we should use for testing going forward.

milktrader commented 10 years ago

Okay, now that the framework is in place, it's time to write some tests! :grinning:

milktrader commented 10 years ago

I need to get my git-fu up to speed and figure out how to squash commits.

papamarkou commented 10 years ago

Ok, your plan makes sense - as long as you also agree with the R comparison, all is great.