search

JuliaStats / TimeModels.jl

Modeling time series in Julia
Other
57 stars 28 forks source link

Allow passing KalmanFiltered type to smoothing process #44

Closed rob-luke closed 8 years ago

rob-luke commented 8 years ago

This can save some processing time. Also added a test

rob-luke commented 8 years ago

@GordStephen The nightly build fails due to an SSL error. Thats not related to the code I touched.

INFO: Cloning METADATA from https://github.com/JuliaLang/METADATA.jl
ERROR: GitError(Code:ECERTIFICATE, Class:SSL, The SSL certificate is invalid)
GordStephen commented 8 years ago

This looks great - I reran the failed tests and the SSL error is gone now, but now tests against the 0.5 nightlies give a lot of deprecation warnings that are causing problems and weird testing behaviour when the log file length maxes out... @milktrader what would you say to cutting off support (and tests) for 0.5- independently of #46 (then we can pull this PR once tests are passing).

GordStephen commented 8 years ago

As a reference point, tests with nightlies on master fail (or loop endlessly) now too - https://travis-ci.org/JuliaStats/TimeModels.jl

milktrader commented 8 years ago

Yes, I'm in favor of not supporting 0.5 for the time being. I'm doing that with TimeSeries, Quandl, MarketData, Timestamps and MarketTechnicals. It will be great once the dust settles, but for now it's probably a good way to avoid headaches.

rob-luke commented 8 years ago

Tests are passing against v0.3 and v0.4. Removed v0.5 testing. as milktrader suggested above.

Ready to merge @GordStephen @milktrader ?

milktrader commented 8 years ago

I'll go in now and start up on NEWS.md and files that will limit this to v0.3. Once we're satisfied that v0.3 is workable and stable, we can tag the last version and move on to isolating this package to work only on v0.4