JuliaStats / TimeModels.jl

Modeling time series in Julia
Other
57 stars 28 forks source link

Prepare package for 0.0.3 #48

Closed milktrader closed 8 years ago

milktrader commented 8 years ago
milktrader commented 8 years ago

Travis fail on 0.3.11

Kalman Filter
  > Time invariant models
    > Building model
ERROR: StateSpaceModel not defined
 in build_model at /home/travis/.julia/v0.3/TimeModels/test/kalman_filter.jl:11
 in anonymous at /home/travis/.julia/v0.3/TimeModels/test/kalman_filter.jl:45
 in context at /home/travis/.julia/v0.3/FactCheck/src/FactCheck.jl:474
 in anonymous at /home/travis/.julia/v0.3/TimeModels/test/kalman_filter.jl:43
 in context at /home/travis/.julia/v0.3/FactCheck/src/FactCheck.jl:474
 in anonymous at /home/travis/.julia/v0.3/TimeModels/test/kalman_filter.jl:42
 in facts at /home/travis/.julia/v0.3/FactCheck/src/FactCheck.jl:448
 in include at ./boot.jl:245
 in include_from_node1 at ./loading.jl:128
 in include at ./boot.jl:245
 in include_from_node1 at loading.jl:128
 in process_options at ./client.jl:285
 in _start at ./client.jl:354
while loading /home/travis/.julia/v0.3/TimeModels/test/kalman_filter.jl, in expression starting on line 38
while loading /home/travis/.julia/v0.3/TimeModels/test/runtests.jl, in expression starting on line 3
=============================[ ERROR: TimeModels ]==============================

But pass locally

✈  311
               _
   _       _ _(_)_     |  A fresh approach to technical computing
  (_)     | (_) (_)    |  Documentation: http://docs.julialang.org
   _ _   _| |_  __ _   |  Type "help()" for help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 0.3.11 (2015-07-27 06:18 UTC)
 _/ |\__'_|_|_|\__'_|  |  
|__/                   |  x86_64-apple-darwin13.4.0

julia> using TimeModels, FactCheck

julia> @test TimeModels all

Kalman Filter 

13 facts verified.
milktrader commented 8 years ago

Tests passing locally for 0.4-rc1

✈  janet
               _
   _       _ _(_)_     |  A fresh approach to technical computing
  (_)     | (_) (_)    |  Documentation: http://docs.julialang.org
   _ _   _| |_  __ _   |  Type "?help" for help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 0.4.0-rc1 (2015-09-09 16:07 UTC)
 _/ |\__'_|_|_|\__'_|  |  
|__/                   |  x86_64-apple-darwin13.4.0

julia> using TimeModels, FactCheck

julia> @test TimeModels all
WARNING: The `=>` syntax is deprecated, use `-->` instead
Kalman Filter
  > Time invariant models
    > Building model
    > Simulations
    > Filtering
    > Smoothing
    > Model fitting
    > Missing data
    > Return sizes
  > Time varying models
    > Building Model
    > Simulations
    > Filtering
      > Correct initial guess
      > Incorrect initial guess
      > Model error
    > Smoothing
  > Linear regression test
  > Correct failure
13 facts verified.

But Travis has similar error to what is failing on 0.3.11

INFO: Testing TimeModels
WARNING: Base.String is deprecated, use AbstractString instead.
WARNING: Base.FloatingPoint is deprecated, use AbstractFloat instead.
WARNING: The `=>` syntax is deprecated, use `-->` instead
Kalman Filter
  > Time invariant models
    > Building model
ERROR: LoadError: LoadError: UndefVarError: StateSpaceModel not defined
 in build_model at /home/travis/.julia/v0.4/TimeModels/test/kalman_filter.jl:11
 in anonymous at /home/travis/.julia/v0.4/TimeModels/test/kalman_filter.jl:45
 in context at /home/travis/.julia/v0.4/FactCheck/src/FactCheck.jl:474
 in anonymous at /home/travis/.julia/v0.4/TimeModels/test/kalman_filter.jl:43
 in context at /home/travis/.julia/v0.4/FactCheck/src/FactCheck.jl:474
 in anonymous at /home/travis/.julia/v0.4/TimeModels/test/kalman_filter.jl:42
 in facts at /home/travis/.julia/v0.4/FactCheck/src/FactCheck.jl:448
 in include at ./boot.jl:261
 in include_from_node1 at ./loading.jl:304
 in include at ./boot.jl:261
 in include_from_node1 at ./loading.jl:304
 in process_options at ./client.jl:308
 in _start at ./client.jl:411
while loading /home/travis/.julia/v0.4/TimeModels/test/kalman_filter.jl, in expression starting on line 38
while loading /home/travis/.julia/v0.4/TimeModels/test/runtests.jl, in expression starting on line 3
=============================[ ERROR: TimeModels ]==============================
milktrader commented 8 years ago

These were passing earlier today screen shot 2015-10-05 at 10 11 58 am

GordStephen commented 8 years ago

I may have run into a similar issue recently with https://github.com/JuliaStats/TimeSeries.jl/pull/211, adding using TimeModels to runtests.jl might fix it? Not sure exactly what's going on there, it seems to be an issue with whether or not the package to be tested is included by default by FactCheck or not.

milktrader commented 8 years ago

Ok, worth a shot. Weird. I put TimeModels in the test/REQUIRE to see if that works. I've never seen an instance though where a package needs to be explicitly required for it to test it.

milktrader commented 8 years ago

Adding it now to test/runtests.jl

REQUIRE didn't do the trick

milktrader commented 8 years ago

Okay, that worked https://travis-ci.org/JuliaStats/TimeModels.jl/jobs/83702302

milktrader commented 8 years ago

https://travis-ci.org/JuliaStats/TimeModels.jl/builds/83702936 with TimeModels removed from test/REQUIRE