JuliaStats / TimeSeries.jl

Time series toolkit for Julia
Other
353 stars 69 forks source link

timearray: Revoke deprecation of `==` and redefine its meaning #357

Closed iblislin closed 6 years ago

iblislin commented 6 years ago
julia> cl == copy(cl)
true

@dourouc05 please review this

codecov-io commented 6 years ago

Codecov Report

Merging #357 into master will increase coverage by 0.23%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
+ Coverage   85.98%   86.22%   +0.23%     
==========================================
  Files          10       10              
  Lines         471      479       +8     
==========================================
+ Hits          405      413       +8     
  Misses         66       66
Impacted Files Coverage Δ
src/timearray.jl 98.49% <100%> (+0.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b66a385...dab9ae1. Read the comment docs.

dourouc05 commented 6 years ago

It works fine for me! (I have never really played with generated functions, so don't count me in for the code review.)

Maybe the docstring could me more informative for users? I am not sure beginners will know what fields a TimeArray has. This is what I propose:

If true, all fields of x and y should be equal, meaning that the two time arrays have the same values at the same points in time, and the same metadata.

iblislin commented 6 years ago

ok, I updated it

iblislin commented 6 years ago

good to go?