JuliaStats / TimeSeries.jl

Time series toolkit for Julia
Other
353 stars 69 forks source link

Julia 0.7 #370

Closed iblislin closed 6 years ago

iblislin commented 6 years ago

TODO:

codecov-io commented 6 years ago

Codecov Report

Merging #370 into master will increase coverage by 12.27%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #370       +/-   ##
===========================================
+ Coverage   86.86%   99.13%   +12.27%     
===========================================
  Files          10        9        -1     
  Lines         510      346      -164     
===========================================
- Hits          443      343      -100     
+ Misses         67        3       -64
Impacted Files Coverage Δ
src/utilities.jl 100% <100%> (ø) :arrow_up:
src/combine.jl 98.43% <100%> (-0.3%) :arrow_down:
src/apply.jl 100% <100%> (+9.09%) :arrow_up:
src/split.jl 100% <100%> (ø) :arrow_up:
src/readwrite.jl 100% <100%> (ø) :arrow_up:
src/broadcast.jl 100% <100%> (+7.69%) :arrow_up:
src/timearray.jl 98.23% <100%> (-0.26%) :arrow_down:
src/basemisc.jl 100% <100%> (+37.5%) :arrow_up:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 157dc5d...cf5032a. Read the comment docs.

femtotrader commented 6 years ago

I think https://github.com/JuliaStats/TimeSeries.jl/blob/b0773e8ce5bdf38d18c5faf5d22b5dcf50134c11/test/runtests.jl#L13

should be removed according

https://travis-ci.org/JuliaStats/TimeSeries.jl/builds/426145131#L673

iblislin commented 6 years ago

This PR is ready for review. Let's support 0.7/1.0 first. And I write down some TODOs in #373

femtotrader commented 6 years ago

LGTM... tests are passing both with Julia 0.7 and 1.0 Thanks @iblis17 for this huge work! The situation is better than it was... if there is some improvements to do I think it can be done in an other PR I can't personally merge this PR I think @ararslan can