search

JuliaStats / TimeSeries.jl

Time series toolkit for Julia
Other
353 stars 69 forks source link

Be specific about exception type. #405

Closed petershintech closed 5 years ago

petershintech commented 5 years ago

Raise a more specific ArgumentError when an unsupported method is given to dropnan().

codecov-io commented 5 years ago

Codecov Report

Merging #405 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #405   +/-   ##
=======================================
  Coverage   70.18%   70.18%           
=======================================
  Files          10       10           
  Lines         550      550           
=======================================
  Hits          386      386           
  Misses        164      164
Impacted Files Coverage Δ
src/apply.jl 78.78% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5cfe95d...bdee40c. Read the comment docs.

petershintech commented 5 years ago

And also for percentage() and setcolnames().

petershintech commented 5 years ago

@iblis17 I found bdee40c is breaking some unit tests. Is it ok to merge it to the master?

iblislin commented 5 years ago

Just send another PR. It's okay.

petershintech commented 5 years ago

Thanks @iblis17