search

JuliaStats / TimeSeries.jl

Time series toolkit for Julia
Other
353 stars 69 forks source link

Support delimiter, header and format when writing time series #406

Closed petershintech closed 5 years ago

petershintech commented 5 years ago

To make writetimearray() symmetric with readtimearray().

codecov-io commented 5 years ago

Codecov Report

Merging #406 into master will increase coverage by 0.1%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #406     +/-   ##
=========================================
+ Coverage   70.18%   70.28%   +0.1%     
=========================================
  Files          10       10             
  Lines         550      552      +2     
=========================================
+ Hits          386      388      +2     
  Misses        164      164
Impacted Files Coverage Δ
src/readwrite.jl 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5cfe95d...2bf332f. Read the comment docs.

petershintech commented 5 years ago

Knock, knock. Anybody who can review these commits?

iblislin commented 5 years ago

ha, okay

petershintech commented 5 years ago

Glad to have attention to my PR. @iblis17 I think this is a nice extension. Please let me know if you have any suggestions.

iblislin commented 5 years ago

I will find free time to test this patch in following few days.

iblislin commented 5 years ago

Thanks for this great contributions! :+1: