Sh4pe commented 5 years ago

The function find is not defined and caused an UndefVarError when this line was executed.

Fixes #432

codecov-io commented 5 years ago

Codecov Report

Merging #433 into master will increase coverage by 1.36%. The diff coverage is 75%.

@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
+ Coverage   85.89%   87.25%   +1.36%     
==========================================
  Files          11       11              
  Lines         475      510      +35     
==========================================
+ Hits          408      445      +37     
+ Misses         67       65       -2

Impacted Files	Coverage Δ
src/plotrecipes.jl	`14.54% <75%> (+14.54%)`	:arrow_up:
src/apply.jl	`96.72% <0%> (-3.28%)`	:arrow_down:
src/combine.jl	`98.48% <0%> (+0.44%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ee109af...576f451. Read the comment docs.

iblislin commented 5 years ago

Hi @Sh4pe could you test the updated patches?

Sh4pe commented 5 years ago

It still does not work and fails inside extract_ohlc. I've added a test that invokes the Candlestick constructor and it fails with the error message

ArgumentError: invalid index: nothing of type Nothing

(The Julia 1.0 build job failed because it could not connect to GitHub. Maybe it needs to be rekicked).

iblislin commented 5 years ago

ah, I fixed the error message. A Candlestick requires theses four columns as inputs: open, high, low, close. A worked example:

using MarketData
TimeSeries.Candlestick(ohlcv)

Sh4pe commented 5 years ago

Ok, got it. I like the solution - no more comments 😄

iblislin commented 5 years ago

Thanks for your contribution.

I'm going to make a new release.

JuliaStats / TimeSeries.jl

Replace find -> findall and fix issue 432 #433

Codecov Report