search

JuliaStats / TimeSeries.jl

Time series toolkit for Julia
Other
349 stars 69 forks source link

combine: fix `collapse` period calculation for Dates accessors methods #499

Closed iblislin closed 3 years ago

iblislin commented 3 years ago

Ref #498.

This PR is the first part for fixing #498. The following works are

  1. Add a new signature of collapse to accept Period type.
  2. Handling type promotion like map does.

@clouds56 Could you try this PR out?

codecov-commenter commented 3 years ago

Codecov Report

Merging #499 (6030acd) into master (59b1003) will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
+ Coverage   88.00%   88.03%   +0.03%     
==========================================
  Files          12       12              
  Lines         700      702       +2     
==========================================
+ Hits          616      618       +2     
  Misses         84       84
Impacted Files Coverage Δ
src/combine.jl 96.77% <100.00%> (+0.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 59b1003...6030acd. Read the comment docs.