Open quinnj opened 2 years ago
The reason that we defined schema
is for the time column.
Since the fallback function return only the data column. for example, [:a, :b, :c]
, but we defined the custom schema
to return [:timestamp, :a, :b, :c]
The reason that we defined
schema
is for the time column. Since the fallback function return only the data column. for example,[:a, :b, :c]
, but we defined the customschema
to return[:timestamp, :a, :b, :c]
Yep, that's perfectly fine/valid.
Reasoning for changes:
rowaccess
/rows
because if we definecolumnaccess
/columns
then we automatically get an efficient fallbackrows
definitioncolumnnames
/getcolumn
/schema
onTimeArray
, only on the type thatTables.columns
returns, so in this case, justTableIter
Tables.columns
first and then callTables.schema(cols)
; callingTables.schema
directly on the table input isn't valid, as it wouldn't work in, for example, the case where someone passed in a::TimeArray
.