JuliaStats / TimeSeries.jl

Time series toolkit for Julia
Other
349 stars 69 forks source link

Remove candletick series labels #505

Closed nilshg closed 1 year ago

nilshg commented 2 years ago

The current recipe produces a separate label for each bar, which completely clutters the plot if a user calls plot(ta; legend = :topleft) (or any other legend position). With this change no labels are produced by default, allowing the user to combine the candlestick plot with other plots and add a legend without having dozens of y1, y2, y3... entries in the legend.

codecov-commenter commented 2 years ago

Codecov Report

Merging #505 (b083203) into master (0356f4b) will decrease coverage by 0.23%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #505      +/-   ##
==========================================
- Coverage   88.13%   87.90%   -0.24%     
==========================================
  Files          12       12              
  Lines         708      711       +3     
==========================================
+ Hits          624      625       +1     
- Misses         84       86       +2     
Impacted Files Coverage Δ
src/plotrecipes.jl 13.92% <0.00%> (-0.37%) :arrow_down:
src/timearray.jl 98.26% <0.00%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0356f4b...b083203. Read the comment docs.

nilshg commented 2 years ago

Bump

iblislin commented 1 year ago

Thanks for your contributions!