search

JuliaStochOpt / ParameterJuMP.jl

A JuMP extension to use parameter in constraints RHS
MIT License
41 stars 5 forks source link

[deprecation] Remove fix in favor of set_value #76

Closed odow closed 3 years ago

odow commented 3 years ago

JuMP's Nonlinear parameters use set_value and value: https://jump.dev/JuMP.jl/stable/nlp/#Nonlinear-Parameters

We should follow that.

codecov[bot] commented 3 years ago

Codecov Report

Merging #76 (f5c97e1) into master (11421e1) will increase coverage by 4.94%. The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   72.06%   77.01%   +4.94%     
==========================================
  Files           8        8              
  Lines         469      435      -34     
==========================================
- Hits          338      335       -3     
+ Misses        131      100      -31
Impacted Files Coverage Δ
src/ParameterJuMP.jl 86.51% <ø> (ø)
src/deprecations.jl 0.00% <0.00%> (ø)
src/variable_interface.jl 52.17% <100.00%> (+27.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 11421e1...594da09. Read the comment docs.

odow commented 3 years ago

Looks like my merge didn't work. Let me try again.