diegozea commented 5 years ago

It solves:

┌ Warning: `float(x::AbstractString)` is deprecated, use `parse(Float64, x)` instead.
│   caller = printfmt(::Base.GenericIOBuffer{Array{UInt8,1}}, ::Formatting.FormatSpec, ::String) at fmtspec.jl:183
└ @ Formatting ~/.julia/dev/Formatting/src/fmtspec.jl:183

coveralls commented 5 years ago

Coverage decreased (-0.4%) to 97.228% when pulling 9efa1108eae041b2cf93e4ad864d020d29b1f9e6 on diegozea:patch-2 into 38b8c498dc96b6ab6653ecec1bb3c73917dbc284 on JuliaString:master.

coveralls commented 5 years ago

Coverage decreased (-0.4%) to 97.228% when pulling 9efa1108eae041b2cf93e4ad864d020d29b1f9e6 on diegozea:patch-2 into 38b8c498dc96b6ab6653ecec1bb3c73917dbc284 on JuliaString:master.

codecov-io commented 5 years ago

Codecov Report

Merging #44 into master will decrease coverage by 0.57%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   97.46%   96.89%   -0.58%     
==========================================
  Files           6        6              
  Lines         513      515       +2     
==========================================
- Hits          500      499       -1     
- Misses         13       16       +3

Impacted Files	Coverage Δ
src/fmtspec.jl	`94.66% <66.66%> (-2.52%)`	:arrow_down:
src/Format.jl	`75% <0%> (-25%)`	:arrow_down:
src/fmt.jl	`98.43% <0%> (-0.05%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 38b8c49...9efa110. Read the comment docs.

ScottPJones commented 4 years ago

This doesn't have a test case, or a rationale for why this would be useful. Sorry I didn't respond about it earlier.

JuliaString / Format.jl

Solve deprecation warning/error on Julia 0.7/1.0 #44

Codecov Report