Closed xiaodaigh closed 6 years ago
Ideally, the julia optimizer would detect the lock and unlock, and hoist them outside the broadcast loop. otherwise, maybe we could overload broadcast (you can't really do that in 0.6, but you can in 0.5 and you might be be able to in 0.7? ) and do that manually.
Other than that, it just generally making it faster, which at this point means making a faster way of hashing strings. Which is totally possible, but I don't care to do it right now. (I would accept a PR. or speak in favor of a PR to Base)
It is in general faster now
Sampling random strings from a samplespace of
String
s is quite fastbut sampling random interned strigns from a sample space of
InternedStrings
is slow.In general, making a long
Vector{InternedStrings}
is quite slow. Not sure what the fix is.