Closed brainandforce closed 3 months ago
could we add tests for these new methods?
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
bca08b0
) 92.95% compared to head (7b26d49
) 92.73%.
Files | Patch % | Lines |
---|---|---|
src/InlineStrings.jl | 71.42% | 2 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I've added some fixes and tests for new ambiguities I've discovered with Base.lstrip
and Base.rstrip
. However, I wasn't sure if it was meaningful to test methods containing a Ptr{<:InlineString}
argument, the reason being that immutable objects do not have stable memory addresses.
In practice nobody should ever be constructing a Ptr{<:InlineString}
. The method definition only exists to resolve the ambiguity.
Could this be merged and tagged?
This doesn't fully solve #64, but it does solve two ambiguities: those between InlineStrings
and Julia Base