search

JuliaStrings / InlineStrings.jl

Fixed-width string types for Julia
Other
45 stars 12 forks source link

Method ambiguities reported by Aqua #71

Closed prbzrg closed 2 months ago

prbzrg commented 9 months ago

In Julia v1.10, I used Aqua to detect method ambiguities in my package https://github.com/impICNF/ContinuousNormalizingFlows.jl/issues/356 and some of its report were related to this package:

Ambiguity #74
defalg(::AbstractArray{<:Union{Missing, InlineStrings.String1, InlineStrings.String15, InlineStrings.String3, InlineStrings.String7}}) @ InlineStrings ~/.julia/packages/InlineStrings/rlLZO/src/InlineStrings.jl:942
defalg(v::AbstractArray{<:Union{Missing, Number}}) @ Base.Sort sort.jl:1350

Possible fix, define
  defalg(::AbstractArray{<:Missing})

Ambiguity #83
lstrip(f, s::InlineStrings.InlineString) @ InlineStrings ~/.julia/packages/InlineStrings/rlLZO/src/InlineStrings.jl:482
lstrip(::AbstractString, ::AbstractString) @ Base strings/util.jl:372

Possible fix, define
  lstrip(::AbstractString, ::InlineStrings.InlineString)

Ambiguity #84
lstrip(f, s::InlineStrings.String1) @ InlineStrings ~/.julia/packages/InlineStrings/rlLZO/src/InlineStrings.jl:481
lstrip(::AbstractString, ::AbstractString) @ Base strings/util.jl:372

Possible fix, define
  lstrip(::AbstractString, ::InlineStrings.String1)

Ambiguity #101
rstrip(f, s::InlineStrings.InlineString) @ InlineStrings ~/.julia/packages/InlineStrings/rlLZO/src/InlineStrings.jl:525
rstrip(::AbstractString, ::AbstractString) @ Base strings/util.jl:406

Possible fix, define
  rstrip(::AbstractString, ::InlineStrings.InlineString)

Ambiguity #102
rstrip(f, s::InlineStrings.String1) @ InlineStrings ~/.julia/packages/InlineStrings/rlLZO/src/InlineStrings.jl:524
rstrip(::AbstractString, ::AbstractString) @ Base strings/util.jl:406

Possible fix, define
  rstrip(::AbstractString, ::InlineStrings.String1)

Ambiguity #113
unsafe_convert(::Type{Ptr{Int8}}, x::Ref{T}) where T<:InlineString @ InlineStrings ~/.julia/packages/InlineStrings/rlLZO/src/InlineStrings.jl:169
unsafe_convert(::Type{P}, x::Ptr) where P<:Ptr @ Base essentials.jl:543

Possible fix, define
  unsafe_convert(::Type{Ptr{Int8}}, ::Ptr{T}) where T<:InlineStrings.InlineString

Ambiguity #114
unsafe_convert(::Type{Ptr{UInt8}}, x::Ref{T}) where T<:InlineString @ InlineStrings ~/.julia/packages/InlineStrings/rlLZO/src/InlineStrings.jl:167
unsafe_convert(::Type{P}, x::Ptr) where P<:Ptr @ Base essentials.jl:543

Possible fix, define
  unsafe_convert(::Type{Ptr{UInt8}}, ::Ptr{T}) where T<:InlineStrings.InlineString

I would appreciate your attention to this issue.

prbzrg commented 9 months ago

Related to #64

ufechner7 commented 6 months ago

Can this be fixed in this package?

KristofferC commented 2 months ago

Let's "merge" this into https://github.com/JuliaStrings/InlineStrings.jl/issues/64