search

JuliaSurv / NetSurvival.jl

A pure-Julia take on standard net survival routines
https://juliasurv.github.io/NetSurvival.jl/
MIT License
6 stars 0 forks source link

[Readme timings] Add timings to readme.md #36

Closed lrnv closed 2 months ago

lrnv commented 2 months ago

Is the "up to 1000x LOC" and "up to 50x perf" realistic ?

rimhajal commented 2 months ago

This is also mentioned in the docs, do I remove it from there as well?

lrnv commented 2 months ago

remove no, correct yes. What is the true perf gain on your machine ? What is the real number of LOC of relsurv for the same functionlities ?

lrnv commented 2 months ago

I linked the issue w.r.t. timings so that it will happen in this branch.

lrnv commented 2 months ago

So this version should be very good. Timings on my machine are in the readme, would you mind running them on your machine and switching if they are better ?

lrnv commented 2 months ago

@rimhajal for me this is good to go after you replaced the numbers with the ones from your computer

lrnv commented 2 months ago

@rimhajal I like those timings! if you agree this could be merged too ?