JuliaSymbolics / Metatheory.jl

Makes Julia reason with equations. General purpose metaprogramming, symbolic computation and algebraic equational reasoning library for the Julia programming language: E-Graphs & equality saturation, term rewriting and more.

https://juliasymbolics.github.io/Metatheory.jl/dev/

MIT License

362 stars 47 forks source link

Fix the library macros #100

Closed 0x0f0f0f closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #100 (b796f45) into master (f316739) will decrease coverage by 0.06%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   75.47%   75.40%   -0.07%     
==========================================
  Files          15       15              
  Lines        1464     1464              
==========================================
- Hits         1105     1104       -1     
- Misses        359      360       +1

Impacted Files	Coverage Δ
src/Library.jl	`100.00% <100.00%> (ø)`
src/EGraphs/intdisjointmap.jl	`72.72% <0.00%> (-2.28%)`	:arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

0x0f0f0f commented 2 years ago

Failing Symbolics.jl test is also failing on master https://github.com/JuliaSymbolics/Symbolics.jl/runs/5235920072?check_suite_focus=true

0x0f0f0f commented 2 years ago

@ChrisRackauckas @shashi could you please confirm that the failing tests are unrelated to the changes?

ChrisRackauckas commented 2 years ago

https://github.com/JuliaSymbolics/Metatheory.jl/runs/5438278144?check_suite_focus=true is unrelated, and the NeuralPDE one is unrelated.

https://github.com/JuliaSymbolics/Metatheory.jl/runs/5438278321?check_suite_focus=true looks related?

0x0f0f0f commented 2 years ago

https://github.com/JuliaSymbolics/Metatheory.jl/runs/5438278144?check_suite_focus=true is unrelated, and the NeuralPDE one is unrelated.

https://github.com/JuliaSymbolics/Metatheory.jl/runs/5438278321?check_suite_focus=true looks related?

I think it's a change in Core.Compiler.return_type. Not sure.

0x0f0f0f commented 2 years ago

seems all good