search

JuliaSymbolics / Metatheory.jl

Makes Julia reason with equations. General purpose metaprogramming, symbolic computation and algebraic equational reasoning library for the Julia programming language: E-Graphs & equality saturation, term rewriting and more.
https://juliasymbolics.github.io/Metatheory.jl/dev/
MIT License
356 stars 47 forks source link

Remove noise in tests, restructure tests, update deps #167

Closed 0x0f0f0f closed 11 months ago

codecov-commenter commented 11 months ago

Codecov Report

Merging #167 (45eb598) into master (4956519) will decrease coverage by 0.96%. The diff coverage is 66.66%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
- Coverage   72.18%   71.22%   -0.96%     
==========================================
  Files          15       15              
  Lines        1330     1317      -13     
==========================================
- Hits          960      938      -22     
- Misses        370      379       +9
Files Coverage Δ
src/EGraphs/egraph.jl 84.96% <100.00%> (-0.38%) :arrow_down:
src/Patterns.jl 70.00% <50.00%> (+4.14%) :arrow_up:
src/Rules.jl 70.17% <66.66%> (-2.24%) :arrow_down:

... and 4 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

0x0f0f0f commented 11 months ago

Minimum supported version in CI should be 1.8

0x0f0f0f commented 11 months ago

@shashi @ChrisRackauckas it seems that even if MT was deprecated in SU and Symbolics, why do we have to still run tests for downstream? How can we fix this? Shouldn't they be skipped automatically?