0x0f0f0f commented 3 years ago

Tests will pass when Rewriters.jl is registered. See https://github.com/JuliaRegistries/General/pull/44045

shashi commented 3 years ago

Need to update the docs to make it clear how to get the rewriters. Maybe just say you will need to add the Rewriters package and do using Rewriters then later we can point to a Rewriters.jl documentation if that exists.

shashi commented 3 years ago

what's up with the repo name? https://github.com/JuliaSymbolics/RewriterCombinators.jl ?

0x0f0f0f commented 3 years ago

@shashi got rejected by Registrator https://github.com/JuliaRegistries/General/pull/44045#issuecomment-911614167

codecov-commenter commented 3 years ago

Codecov Report

Merging #352 (6f5ae51) into master (686f765) will increase coverage by 1.21%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #352      +/-   ##
==========================================
+ Coverage   83.81%   85.02%   +1.21%     
==========================================
  Files          12       11       -1     
  Lines        1446     1356      -90     
==========================================
- Hits         1212     1153      -59     
+ Misses        234      203      -31

Impacted Files	Coverage Δ
src/utils.jl	`57.84% <ø> (-0.82%)`	:arrow_down:
src/rule.jl	`86.77% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 686f765...6f5ae51. Read the comment docs.

0x0f0f0f commented 3 years ago

Anything missing to merge this PR?

0x0f0f0f commented 3 years ago

Merged latest master

0x0f0f0f commented 3 years ago

All green!!

0x0f0f0f commented 3 years ago

Temporarily closing because of https://discourse.julialang.org/t/a-recap-of-the-state-of-the-symbolics-ecosystem/68022

JuliaSymbolics / SymbolicUtils.jl

Split Rewriters module into different package #352

Codecov Report