search

JuliaSymbolics / SymbolicUtils.jl

Symbolic expressions, rewriting and simplification
https://docs.sciml.ai/SymbolicUtils/stable/
Other
545 stars 114 forks source link

Updated TermInterface.jl #360

Closed 0x0f0f0f closed 3 years ago

0x0f0f0f commented 3 years ago

Added exprhead that is used by MT's pattern matcher to match against the <:Pattern types. Fundamental in order to make the e-graph rewriting of symbolics to work. Added unsorted_arguments to TermInterface

Now default interface for Expr is polished. TODO: add documentation saying that using Expr as Symbolic types is not probably a good idea.

shashi commented 3 years ago

The symbolics test failure is a real one. Need to fix it.

0x0f0f0f commented 3 years ago

The symbolics test failure is a real one. Need to fix it.

Fixed in https://github.com/JuliaSymbolics/SymbolicUtils.jl/pull/368/commits/3df6bf194a4f1750574defe2c25ee18e2a4e1fc4

0x0f0f0f commented 3 years ago

@shashi The buildkite test is failing saying that a function (that is defined!) is not defined. https://buildkite.com/julialang/symbolicutils-dot-jl/builds/161#ab7ec85c-0ae5-4bd6-ab38-d34b6fbac1e2/261-557

0x0f0f0f commented 3 years ago

Superseded by #368