JuliaSymbolics / SymbolicUtils.jl

Symbolic expressions, rewriting and simplification
https://docs.sciml.ai/SymbolicUtils/stable/
Other
536 stars 107 forks source link

WIP: Preserve metadata in simplify_fractions #379

Open YingboMa opened 2 years ago

YingboMa commented 2 years ago

@shashi the test still fails. Do you have some clues?

codecov-commenter commented 2 years ago

Codecov Report

Merging #379 (b722816) into master (48cc5ff) will decrease coverage by 0.34%. The diff coverage is 100.00%.

:exclamation: Current head b722816 differs from pull request most recent head 3d3ae9a. Consider uploading reports for the commit 3d3ae9a to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
- Coverage   83.70%   83.35%   -0.35%     
==========================================
  Files          12       12              
  Lines        1479     1478       -1     
==========================================
- Hits         1238     1232       -6     
- Misses        241      246       +5     
Impacted Files Coverage Δ
src/polyform.jl 92.72% <100.00%> (-1.40%) :arrow_down:
src/ordering.jl 89.53% <0.00%> (-1.17%) :arrow_down:
src/code.jl 80.55% <0.00%> (-0.56%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 48cc5ff...3d3ae9a. Read the comment docs.

shashi commented 2 years ago

It is likely getting lost in the round trip to DynamicPolynomials. I didn't take care of this when doing polyform. Will have a look.