search

JuliaSymbolics / SymbolicUtils.jl

Symbolic expressions, rewriting and simplification
https://docs.sciml.ai/SymbolicUtils/stable/
Other
536 stars 107 forks source link

re-evaluate default behavior of similarterm #381

Open shashi opened 2 years ago

shashi commented 2 years ago

We often try to use Postwalk and lose metadata and type information when re-constructing expressions and end up having to define simterm and pass it to Postwalk every time. We should re-evaluate how similarterm should transfer these by default. I am for carrying over the type and metadata from the reference term by default whenever we know it.

cc @YingboMa -- I think it started with your change originally to fix the old to_mpoly. cc @0x0f0f0f

0x0f0f0f commented 2 years ago

I think after #368 is merged this issue should be moved to TermInterface.jl and Metatheory.jl