WIP: create_bindings in DestructuredArgs

JuliaSymbolics / SymbolicUtils.jl

Symbolic expressions, rewriting and simplification

https://docs.sciml.ai/SymbolicUtils/stable/

Other

536 stars 107 forks source link

WIP: create_bindings in DestructuredArgs #406

Closed shashi closed 2 years ago

shashi commented 2 years ago

Allow avoiding creating let bindings if necessary.

shashi commented 2 years ago

Hmm, those failures are numerical and deviate significantly outside of tolerance, I doubt this change is the cause, but if anyone thinks it's likely let me know. cc @ChrisRackauckas @YingboMa

shashi commented 2 years ago

cc @KirillZubov

ChrisRackauckas commented 2 years ago

Does it work on v1.6? I heard Flux has some issues with restructure/destructure on v1.7.

shashi commented 2 years ago

it seems to work on 1.6 btw...

shashi commented 2 years ago

We have the same failure on master without this change (on v1.7). I think the tests there need to be updated or @test_broken.