search

JuliaSymbolics / SymbolicUtils.jl

Symbolic expressions, rewriting and simplification
https://docs.sciml.ai/SymbolicUtils/stable/
Other
536 stars 107 forks source link

ndims() and broadcast() definitions for generic symbolic types #409

Closed gronniger closed 2 years ago

gronniger commented 2 years ago

This PR defines ndims() in terms of the type that a symbolic expression represents. That should be correct also for future/custom types. Broadcast assumes all types are "scalar" until defined otherwise.

codecov-commenter commented 2 years ago

Codecov Report

Merging #409 (76c9c7a) into master (16066fa) will increase coverage by 0.46%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #409      +/-   ##
==========================================
+ Coverage   83.32%   83.78%   +0.46%     
==========================================
  Files          12       12              
  Lines        1319     1338      +19     
==========================================
+ Hits         1099     1121      +22     
+ Misses        220      217       -3
Impacted Files Coverage Δ
src/methods.jl 82.60% <66.66%> (+1.21%) :arrow_up:
src/ordering.jl 88.37% <0.00%> (-1.17%) :arrow_down:
src/adjoints.jl 100.00% <0.00%> (ø)
src/polyform.jl 93.88% <0.00%> (+0.16%) :arrow_up:
src/types.jl 84.39% <0.00%> (+0.78%) :arrow_up:
src/simplify_rules.jl 91.66% <0.00%> (+9.84%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 16066fa...76c9c7a. Read the comment docs.