JuliaSymbolics / SymbolicUtils.jl

Symbolic expressions, rewriting and simplification
https://docs.sciml.ai/SymbolicUtils/stable/
Other
541 stars 108 forks source link

simplify() action different from juliasymbolics.org #444

Open acsofie opened 2 years ago

acsofie commented 2 years ago

I am learning SymbolicUtils from juliasymbolics.org and got different answer of simplify().

julia> using SymbolicUtils

julia> @syms w z α::Real β::Real
(w, z, α, β)

julia> simplify(2 * (w+w+α+β + sin(z)^2 + cos(z)^2 - 1)) # should be 2(α + β + 2w) from https://symbolicutils.juliasymbolics.org/#simplification
4w + 2α + 2β + 2(cos(z)^2) + 2(sin(z)^2) - 2

julia> simplify(2 * (sin(z)^2 + cos(z)^2)) # should be 2
2(cos(z)^2) + 2(sin(z)^2)

julia> simplify(sin(z)^2 + cos(z)^2)
1

Environment:

Julia Version 1.8.0-beta3 (2022-03-29)
[d1185830] SymbolicUtils v0.19.7
YingboMa commented 2 years ago

@shashi could you take a look?

karlwessel commented 1 week ago

This was fixed at some point:

julia> using SymbolicUtils
julia> @syms w z α::Real β::Real
(w, z, α, β)

julia> simplify(2 * (w+w+α+β + sin(z)^2 + cos(z)^2 - 1)) # should be 2(α + β + 2w) from https://symbolicutils.juliasymbolics.org/#simplification
2(2w + α + β)

julia> simplify(2 * (sin(z)^2 + cos(z)^2)) # should be 2
2

julia> simplify(sin(z)^2 + cos(z)^2)
1