added rule for 1^x == 1 in POW_RULES

JuliaSymbolics / SymbolicUtils.jl

Symbolic expressions, rewriting and simplification

https://docs.sciml.ai/SymbolicUtils/stable/

Other

527 stars 100 forks source link

Closed pagnani closed 1 year ago

pagnani commented 1 year ago

Brought this up on discourse, and relative to issue 437.
It basically introduces a new simplification rule that sets, as for the title, the rule 1^x == 1, which should be ok for all x.
Mathematica enforces it by default, and it seems a good idea to have it here.

YingboMa commented 1 year ago

The failure is real.

pagnani commented 1 year ago

Yeah, there was a typo in the test. Test now pass locally ...

pagnani commented 1 year ago

Is there anything more to do here?