shashi
commented
4 months ago Would be useful to see what is the breakage apart from CI failing due to depwarn explosion.
Closed devmotion closed 2 months ago
shashi
commented
4 months ago Would be useful to see what is the breakage apart from CI failing due to depwarn explosion.
devmotion
commented
4 months ago The depwarns are annoying but they don't cause errors (at least not in my CI setup). The actual problem for me other that it broke tests - from all green everything went to all red. It's a private package so I can't share a link but I'll see if I can come up with a simple reproducer.
devmotion
commented
4 months ago A simple example (inspired by test/linearity.jl in MTK):
julia> using ModelingToolkit
julia> # Define some variables
@parameters t σ ρ β
4-element Vector{Num}:
t
σ
ρ
β
julia> @variables x(t) y(t) z(t)
3-element Vector{Num}:
x(t)
y(t)
z(t)
julia> D = Differential(t)
(::Differential) (generic function with 3 methods)
julia> eqs = [D(x) ~ σ * (y - x),
D(y) ~ -z - y,
D(z) ~ y - β * z]
3-element Vector{Equation}:
Differential(t)(x(t)) ~ (-x(t) + y(t))*σ
Differential(t)(y(t)) ~ -y(t) - z(t)
Differential(t)(z(t)) ~ y(t) - z(t)*β
julia> ModelingToolkit.islinear(@named sys = ODESystem(eqs, t))
ERROR: MethodError: no method matching operation(::Symbolics.TermCombination)
Closest candidates are:
operation(::SymbolicUtils.Code.Assignment)
@ SymbolicUtils ~/.julia/packages/SymbolicUtils/qyMYa/src/utils.jl:224
operation(::SymbolicUtils.Code.DestructuredArgs)
@ SymbolicUtils ~/.julia/packages/SymbolicUtils/qyMYa/src/utils.jl:224
operation(::SymbolicUtils.Code.MakeTuple)
@ SymbolicUtils ~/.julia/packages/SymbolicUtils/qyMYa/src/utils.jl:224
...
Stacktrace:
[1] (::SymbolicUtils.Rewriters.Walk{:pre, Symbolics.var"#295#305"{Dict{…}}, typeof(Symbolics.basic_simterm), false})(x::SymbolicUtils.BasicSymbolic{Real})
@ SymbolicUtils.Rewriters ~/.julia/packages/SymbolicUtils/qyMYa/src/rewriters.jl:205
...
julia> ModelingToolkit.isaffine(@named sys = ODESystem(eqs, t))
ERROR: MethodError: no method matching operation(::Symbolics.TermCombination)
Closest candidates are:
operation(::SymbolicUtils.Code.Assignment)
@ SymbolicUtils ~/.julia/packages/SymbolicUtils/qyMYa/src/utils.jl:224
operation(::SymbolicUtils.Code.DestructuredArgs)
@ SymbolicUtils ~/.julia/packages/SymbolicUtils/qyMYa/src/utils.jl:224
operation(::SymbolicUtils.Code.MakeTuple)
@ SymbolicUtils ~/.julia/packages/SymbolicUtils/qyMYa/src/utils.jl:224
...
Stacktrace:
[1] (::SymbolicUtils.Rewriters.Walk{:pre, Symbolics.var"#295#305"{Dict{…}}, typeof(Symbolics.basic_simterm), false})(x::SymbolicUtils.BasicSymbolic{Real})
@ SymbolicUtils.Rewriters ~/.julia/packages/SymbolicUtils/qyMYa/src/rewriters.jl:205
...Setup:
shashi
commented
4 months ago Thanks!!
jbcaillau
commented
4 months ago Hi, same no method matching operation(::Symbolics.TermCombination) error in OptimalControl.jl and related packages that rely on ADNLModels.jl, the latter using Symbolics.jl for sparsity pattern analysis (@tmigot and @amontoison can be more specific about this). Check this issue.
Any help on how to downgrade waiting for a fix is appreciated!
ChrisRackauckas
commented
2 months ago This got fixed.
Originally posted by @devmotion in https://github.com/JuliaSymbolics/SymbolicUtils.jl/issues/584#issuecomment-2109056973