JuliaSymbolics / SymbolicUtils.jl

Symbolic expressions, rewriting and simplification
https://docs.sciml.ai/SymbolicUtils/stable/
Other
523 stars 99 forks source link

similarterm -> maketerm in Walk and PolyForm #603

Closed shashi closed 1 month ago

shashi commented 1 month ago

Should fix depwarns from within.

github-actions[bot] commented 1 month ago

Benchmark Results

master 0520c789d8e27c... master/0520c789d8e27c...
overhead/acrule/a+2 0.761 ± 0.022 μs 0.76 ± 0.021 μs 1
overhead/acrule/a+2+b 0.744 ± 0.021 μs 0.733 ± 0.025 μs 1.02
overhead/acrule/a+b 0.269 ± 0.0071 μs 0.258 ± 0.007 μs 1.04
overhead/acrule/noop:Int 25.4 ± 0.92 ns 25.9 ± 0.93 ns 0.979
overhead/acrule/noop:Sym 0.0368 ± 0.0058 μs 0.0365 ± 0.0055 μs 1.01
overhead/rule/noop:Int 0.0437 ± 0.00054 μs 0.0439 ± 0.0011 μs 0.996
overhead/rule/noop:Sym 0.0547 ± 0.0029 μs 0.0555 ± 0.0025 μs 0.985
overhead/rule/noop:Term 0.055 ± 0.0027 μs 0.0548 ± 0.0026 μs 1.01
overhead/ruleset/noop:Int 0.127 ± 0.0032 μs 0.132 ± 0.0038 μs 0.964
overhead/ruleset/noop:Sym 0.151 ± 0.0051 μs 0.148 ± 0.0053 μs 1.02
overhead/ruleset/noop:Term 3.56 ± 0.16 μs 3.94 ± 0.19 μs 0.904
overhead/simplify/noop:Int 0.145 ± 0.0029 μs 0.143 ± 0.004 μs 1.02
overhead/simplify/noop:Sym 0.166 ± 0.005 μs 0.152 ± 0.0048 μs 1.09
overhead/simplify/noop:Term 0.0391 ± 0.0021 ms 0.039 ± 0.0023 ms 1
overhead/simplify/randterm (+, *):serial 0.121 ± 0.0012 s 0.125 ± 0.0066 s 0.966
overhead/simplify/randterm (+, *):thread 0.0732 ± 0.028 s 0.0747 ± 0.025 s 0.979
overhead/simplify/randterm (/, *):serial 0.225 ± 0.0085 ms 0.231 ± 0.0084 ms 0.974
overhead/simplify/randterm (/, *):thread 0.257 ± 0.0095 ms 0.264 ± 0.0095 ms 0.973
overhead/substitute/a 0.0585 ± 0.0017 ms 0.0594 ± 0.0017 ms 0.984
overhead/substitute/a,b 0.0517 ± 0.0017 ms 0.0518 ± 0.0018 ms 0.998
overhead/substitute/a,b,c 17 ± 0.8 μs 17 ± 0.84 μs 0.995
polyform/easy_iszero 0.0322 ± 0.0023 ms 0.0346 ± 0.0022 ms 0.93
polyform/isone 3.1 ± 0.01 ns 2.79 ± 0.01 ns 1.11
polyform/iszero 1.78 ± 0.039 ms 1.82 ± 0.039 ms 0.98
polyform/simplify_fractions 2.41 ± 0.056 ms 2.58 ± 0.049 ms 0.935
time_to_load 4.54 ± 0.047 s 4.47 ± 0.044 s 1.02

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).