JuliaSymbolics / Symbolics.jl

Symbolic programming for the next generation of numerical software
https://symbolics.juliasymbolics.org/stable/
Other
1.32k stars 146 forks source link

Add ADTypes sparsity detector #1134

Closed gdalle closed 4 weeks ago

gdalle commented 1 month ago

Following the release of ADTypes.jl v1.0, this PR adds a SymbolicsSparsityDetector struct that implements the new sparsity pattern detection framework.

gdalle commented 1 month ago

@ChrisRackauckas this is part of the great wave of updates

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.94%. Comparing base (79c4e92) to head (07fdabd). Report is 198 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1134 +/- ## ========================================== - Coverage 77.07% 75.94% -1.13% ========================================== Files 32 36 +4 Lines 3533 3692 +159 ========================================== + Hits 2723 2804 +81 - Misses 810 888 +78 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gdalle commented 1 month ago

@Vaibhavdixit02 I think the NonLinearSolve upgrade needs to come first before this one. Let me know if you need help

gdalle commented 1 month ago

The only test failure that seems relevant is the downstream test with ModelingToolkit (https://github.com/JuliaSymbolics/Symbolics.jl/actions/runs/9127346950/job/25097459503?pr=1134).

I think it is happening because OptimizationBase has not yet fully embraced ADTypes v1.0 (see https://github.com/SciML/OptimizationBase.jl/issues/44). @Vaibhavdixit02 what do you think?

ChrisRackauckas commented 1 month ago

Can you rebase onto the depwarn fixes?

gdalle commented 1 month ago

done

gdalle commented 1 month ago

Not sure that was a great idea though, nearly all tests fail on master now :thinking:

ChrisRackauckas commented 1 month ago

@shashi is handling a big update over the next week, after which we will revisit this PR.

gdalle commented 1 month ago

No rush!

gdalle commented 1 month ago

Gentle bump on this one, it's absolutely non-destructive and would be useful for benchmarking