Closed gdalle closed 4 weeks ago
@ChrisRackauckas this is part of the great wave of updates
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 75.94%. Comparing base (
79c4e92
) to head (07fdabd
). Report is 198 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@Vaibhavdixit02 I think the NonLinearSolve upgrade needs to come first before this one. Let me know if you need help
The only test failure that seems relevant is the downstream test with ModelingToolkit (https://github.com/JuliaSymbolics/Symbolics.jl/actions/runs/9127346950/job/25097459503?pr=1134).
I think it is happening because OptimizationBase has not yet fully embraced ADTypes v1.0 (see https://github.com/SciML/OptimizationBase.jl/issues/44). @Vaibhavdixit02 what do you think?
Can you rebase onto the depwarn fixes?
done
Not sure that was a great idea though, nearly all tests fail on master now :thinking:
@shashi is handling a big update over the next week, after which we will revisit this PR.
No rush!
Gentle bump on this one, it's absolutely non-destructive and would be useful for benchmarking
Following the release of ADTypes.jl v1.0, this PR adds a
SymbolicsSparsityDetector
struct that implements the new sparsity pattern detection framework.SymbolicsSparsityDetector
structADTypes.jacobian_sparsity
andADTypes.hessian_sparsity
for general arrays, not just vectors