search

JuliaTesting / Aqua.jl

Auto QUality Assurance for Julia packages
MIT License
339 stars 25 forks source link

Improve error when [extras] and test/Project.toml inconsistent #234

Closed fingolfin closed 12 months ago

fingolfin commented 12 months ago

It is very easy to miss that this error only occurs because of a missing compat entry for Julia...

codecov[bot] commented 12 months ago

Codecov Report

Merging #234 (4da9c64) into master (3ea2897) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #234   +/-   ##
=======================================
  Coverage   76.17%   76.17%           
=======================================
  Files          11       11           
  Lines         768      768           
=======================================
  Hits          585      585           
  Misses        183      183
Flag Coverage Δ
unittests 76.17% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/project_extras.jl 98.00% <100.00%> (ø)

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

lgoettgens commented 12 months ago

Could you please make the formatter job happy and add a one-liners to the changelog? Then this is good to go from my POV