Closed NHDaly closed 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
28d29dc
) 75.20% compared to head (a112dd5
) 75.20%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I see where this is coming from and how this can be useful. Some comment from the first look: I would prefer expr
to be a kwarg. In Aqua, we usually use kwargs for everything apart from the Package to test.
Furthermore, there are merge conflicts with https://github.com/JuliaTesting/Aqua.jl/pull/256 and https://github.com/JuliaTesting/Aqua.jl/pull/250. Could you have a look at those? I think most should be due to the docstring being mostly moved to a docs page.
Okay! Thanks @lgoettgens.
I rebased on master, fixed the merge conflicts, added a test case, and changed expr to a keyword argument.
The reason I had made it a positional argument at first was because I wasn't sure what a good name should be. Is expr okay? Should it be precompile_expr?
The reason I had made it a positional argument at first was because I wasn't sure what a good name should be. Is
expr
okay? Should it beprecompile_expr
?
I have no real preference between the two.
Thanks! Should be all done then
(From this slack discussion)
Here's an example of it working!