search

JuliaTesting / Aqua.jl

Auto QUality Assurance for Julia packages
MIT License
334 stars 24 forks source link

Update stale deps stdlibs known bug warning #266

Closed LilithHafner closed 6 months ago

LilithHafner commented 6 months ago

I just got this error

Stale dependencies: Test Failed at /home/x/.julia/packages/Aqua/9p8ck/src/stale_deps.jl:31
  Expression: isempty(stale_deps)
   Evaluated: isempty(Base.PkgId[Base.PkgId(Base.UUID("9e88b42a-f829-5b0c-bbe9-9e923198166b"), "Serialization")])

So I think this bug is fixed.

Would tests be expected for this PR?

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.20%. Comparing base (34a1a02) to head (421a0e1). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #266 +/- ## ======================================= Coverage 75.20% 75.20% ======================================= Files 11 11 Lines 750 750 ======================================= Hits 564 564 Misses 186 186 ``` | [Flag](https://app.codecov.io/gh/JuliaTesting/Aqua.jl/pull/266/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaTesting) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/JuliaTesting/Aqua.jl/pull/266/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaTesting) | `75.20% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaTesting#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lgoettgens commented 6 months ago

Thanks for the report! After creating a MWE and testing with different julia versions, Serialization gets reported as a stale dep in 1.11.0-alpha1 and nightly, but not in 1.10.2. My guess is that this is due to the removal from the sysimg (https://github.com/JuliaLang/julia/pull/51399). Other stdlibs that are still in the sysimg (e.g. LinearAlgebra) still won't get detected.

Thus instead of removing the warning, I would change the "stdlib" to "package in the sysimage" or something.

LilithHafner commented 6 months ago

I suspected that too, and even tested it to confirm. I must have made a mistake. I'll update the PR