JuliaTesting / Aqua.jl

Auto QUality Assurance for Julia packages
MIT License
334 stars 24 forks source link

Make broken tests less noisy #272

Closed lgoettgens closed 5 months ago

lgoettgens commented 5 months ago

Resolves https://github.com/JuliaTesting/Aqua.jl/issues/231.

The tests that may print long lists of things now only do that in the case of a failure. If the test is supplied broken=true, only the number of instances is printed instead.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 63.63636% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 75.06%. Comparing base (6f3067c) to head (e6d4ab0).

Files Patch % Lines
src/piracies.jl 16.66% 5 Missing :warning:
src/exports.jl 66.66% 3 Missing :warning:
src/ambiguities.jl 83.33% 2 Missing :warning:
src/unbound_args.jl 66.66% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #272 +/- ## ========================================== - Coverage 75.46% 75.06% -0.41% ========================================== Files 11 11 Lines 750 762 +12 ========================================== + Hits 566 572 +6 - Misses 184 190 +6 ``` | [Flag](https://app.codecov.io/gh/JuliaTesting/Aqua.jl/pull/272/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaTesting) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/JuliaTesting/Aqua.jl/pull/272/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaTesting) | `75.06% <63.63%> (-0.41%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaTesting#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lgoettgens commented 5 months ago

Is this how you imagined it @jishnub?

jishnub commented 5 months ago

Yes, thanks, this looks exactly like what I wanted