JuliaTesting / Aqua.jl

Auto QUality Assurance for Julia packages
MIT License
334 stars 24 forks source link

Use custom printing of UUIDs instead of relying on Base #275

Closed lgoettgens closed 5 months ago

lgoettgens commented 5 months ago

Julia changed the printing in https://github.com/JuliaLang/julia/pull/52795 which then made our tests fail as we check against a concrete string.

Resolves https://github.com/JuliaTesting/Aqua.jl/issues/274.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.46%. Comparing base (e4403bd) to head (1b1a729).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #275 +/- ## ========================================== + Coverage 75.20% 75.46% +0.26% ========================================== Files 11 11 Lines 750 750 ========================================== + Hits 564 566 +2 + Misses 186 184 -2 ``` | [Flag](https://app.codecov.io/gh/JuliaTesting/Aqua.jl/pull/275/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaTesting) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/JuliaTesting/Aqua.jl/pull/275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaTesting) | `75.46% <100.00%> (+0.26%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaTesting#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.