JuliaTesting / Aqua.jl

Auto QUality Assurance for Julia packages
MIT License
335 stars 24 forks source link

Potential inconsistency: Compat versioning of base packages #294

Open AhmedSalih3d opened 1 month ago

AhmedSalih3d commented 1 month ago

Hi!

First and foremost, nice project! Really helpful.

In regards to my issue, I noticed that when running Aquas test suite, it would complain/error out when versioning info for base packages were not provided, for example Dates = "1.10" was a must to pass the test. In reality it is not a big deal since it follows the version numbering of Julia it self, but I noticed that the Julia manual specifies:

https://github.com/JuliaLang/Pkg.jl/blob/master/docs/src/managing-packages.md image

Perhaps there is no easy way to tell Aqua that something is a "Base package", but just wanted to highlight this small inconsistency I found.

Kind regards

lgoettgens commented 1 month ago

Please see https://discourse.julialang.org/t/psa-compat-requirements-in-the-general-registry-are-changing/104958 for some context. Although all of the changes described there are paused at the moment (afaik), we kept this test in Aqua like this, since we expect something similar to be approached by the julia dev team in the near future again.

For the issue that you pointed out in the Pkg.jl docs, it would be great to open an issue in the https://github.com/JuliaLang/Pkg.jl repository.