search

JuliaTesting / ReferenceTests.jl

Utility package for comparing data against reference files
https://juliatesting.github.io/ReferenceTests.jl/latest/
Other
82 stars 14 forks source link

`ImageInTerminal` 0.5 #115

Closed t-bltg closed 1 year ago

t-bltg commented 1 year ago

circular dep (bump patch needed).

t-bltg commented 1 year ago

Thanks !

johnnychen94 commented 1 year ago

Oops, actually this will be a breaking change since how text image is encoded is changed (reference test will fail).

I'll watch if people hit this issue and see if we need fixes somewhere.

t-bltg commented 1 year ago

I'll keep an eye on that too.

oxinabox commented 1 year ago

oops, sorry. My bad i should have waited til CI finished before merging.

t-bltg commented 1 year ago

My bad i should have waited til CI finished before merging.

Not your fault this was induced by the circular dependency and is clearly a corner case !