ReferenceTests is not compatible with ImageInTerminal `0.5.0`

[adrhill]

ReferenceTests makes use of ImageInTerminal's encodeimg, which appears to have been deprecated in ImageInTerminal 0.5.0. https://github.com/JuliaTesting/ReferenceTests.jl/blob/852eba73a7401ba9d505f7c4ef169ae1aa5ae17a/src/fileio.jl#L59

However ImageInTerminal 0.5.0 is allowed in [compat]: https://github.com/JuliaTesting/ReferenceTests.jl/blob/852eba73a7401ba9d505f7c4ef169ae1aa5ae17a/Project.toml#L28

This currently breaks CI of packages using ReferenceTests. @t-bltg

[t-bltg]

Sorry about that. Hum it seems that ci wasn't even green before merging https://github.com/JuliaTesting/ReferenceTests.jl/pull/115. ==> This was induced by the circular dependency.

@oxinabox , @johnnychen94 , should we yank and rework that release since it already seems to affect users ?

The circular dependency makes it not ideal for testing before releasing...

[juliohm]

I confirm that the issue is affecting my tests as well.

Em ter., 9 de ago. de 2022 19:09, t-bltg @.***> escreveu:

Sorry about that. Hum it seems that ci wasn't even gree before merging

115 https://github.com/JuliaTesting/ReferenceTests.jl/pull/115.

@oxinabox https://github.com/oxinabox , @johnnychen94 https://github.com/johnnychen94 , should we yank and rework that release since it already affects users ?

The circular dependency makes it not ideal for testing before releasing...

— Reply to this email directly, view it on GitHub https://github.com/JuliaTesting/ReferenceTests.jl/issues/116#issuecomment-1209941564, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZQW3MF6SN34JXHOVMIKTTVYLJIVANCNFSM56CKGGQQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[t-bltg]

Yeah if someone could yank that one quickly, I'll sort it out tomorrow (afk right now).

[IanButterworth]

https://github.com/JuliaRegistries/General/pull/65983

[IanButterworth]

Yanked

[johnnychen94]

The next question is, will a ReferenceTests breaking release 0.10 be acceptable?

I know many people don't hardcode the compat section for their test dependencies, so they'll still see their CI red if some of the test depend on the text reference version of an image, e.g., @test_reference "imagetest1.txt" testimage("cameraman").

[t-bltg]

I know many people don't hardcode the compat section for their test dependencies

I guess the root cause of not writing test [compat] is the new test depencencies spec (test/Project.toml) not being complete, over the old one.

The next question is, will a ReferenceTests breaking release 0.10 be acceptable?

Well ... code isn't written in stone, so we should be able to release a breaking version (minor bump).