search

JuliaTesting / ReferenceTests.jl

Utility package for comparing data against reference files
https://juliatesting.github.io/ReferenceTests.jl/latest/
Other
82 stars 14 forks source link

make pipeline cleaner #33

Closed johnnychen94 closed 4 years ago

johnnychen94 commented 4 years ago

The first commit flattens the nested code structure by removing the try-catch block. There're no function changes except using isfile to check if reference file exists. (Is there any special reason using try-catch here?)

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.1%) to 84.605% when pulling 1764e98b438cc7e2b41c7da0b6c8b35004ac5e58 on johnnychen94:pipeline into 31901cae651576e88788b0edd98be8e2161edf8e on Evizero:master.

oxinabox commented 4 years ago

Nice, good improvement. Can also split the content of the two branchs of the if into their own functions. One for handing non-existant file (handle_nonextistant ?), and one for handling disagreeing contents (handle_disagreement ?).

johnnychen94 commented 4 years ago

Mind to merge this? I'd like to open a new PR based on this so that it's easier to be reviewed.

oxinabox commented 4 years ago

I stand by my above comments re breaking it into more functions.

johnnychen94 commented 4 years ago

Ahh, yes, but I have"better" ideas than simply breaking it into parts, and that would change the code structure.

johnnychen94 commented 4 years ago

Or I could push commits into this branch if you like.

oxinabox commented 4 years ago

Ok lets merge this first.