JuliaTesting / ReferenceTests.jl

Utility package for comparing data against reference files
https://juliatesting.github.io/ReferenceTests.jl/latest/
Other
82 stars 14 forks source link

correct the rendermode for txt images #46

Closed johnnychen94 closed 4 years ago

johnnychen94 commented 4 years ago

If we call @test_reference "references/camera_new.txt" camera size=(5,10) it would print an "endless" string... It's definitely a bug here.

johnnychen94 commented 4 years ago

Recent package updates break the test here; it didn't fail on my local machine until I do:

(ReferenceTests) pkg> up
  Updating registry at `~/.julia/registries/General`
  Updating git-repo `https://gitlab.lflab.cn/julialang/JuliaRegistries/General.git`
 Resolving package versions...
  Updating `~/Documents/Julia/ReferenceTests.jl/Project.toml`
  [5789e2e9] ↑ FileIO v1.0.7 ⇒ v1.2.1
  [a09fc81d] ↑ ImageCore v0.8.5 ⇒ v0.8.10
  [d8c32880] ↑ ImageInTerminal v0.4.0 ⇒ v0.4.2

CI on the latest commit also failed after I retriggered it.

The test I add here actually passes:

Reference file for "camera_new.txt" does not exist.
- NEW CONTENT -----------------
eltype: Gray{Normed{UInt8,8}}
size: (512, 512)
thumbnail:
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀

Update: the cause is narrowed down to FixedPointNumbers v0.7.0, but I need more time to find a solution.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.8%) to 83.077% when pulling 485f02a7fc5e375c3f877b1234324e649c0a1864 on johnnychen94:jc/render into eb93dfcb1fa114083837834614ea423d70244c75 on Evizero:master.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.8%) to 83.077% when pulling 485f02a7fc5e375c3f877b1234324e649c0a1864 on johnnychen94:jc/render into eb93dfcb1fa114083837834614ea423d70244c75 on Evizero:master.