save converted actual result as reference

JuliaTesting / ReferenceTests.jl

Utility package for comparing data against reference files

https://juliatesting.github.io/ReferenceTests.jl/latest/

Other

82 stars 14 forks source link

save converted actual result as reference #50

Closed johnnychen94 closed 4 years ago

johnnychen94 commented 4 years ago

For images as txt, we should save the converted string contents: savefile(file, actual) instead of images savefile(file, raw_actual).

Another bug I introduced in #37 😂

No test for this because interactive REPL is required.

coveralls commented 4 years ago

Coverage increased (+0.6%) to 83.721% when pulling a347c6e346c8d2a5e95126d72cb7df15b5d6722b on jc/new_ref into 9a5ae50291c65d8fc7930decbd1135fd688158ce on master.

johnnychen94 commented 4 years ago

I forgot to do a rebase on latest master branch before pushing this. Since the PR test has passed I'll just merge it without waiting for another round of tests.